Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interceptors/validator] feat: add error logging in validator #544

Merged
merged 8 commits into from Mar 26, 2023
Merged

[interceptors/validator] feat: add error logging in validator #544

merged 8 commits into from Mar 26, 2023

Commits on Mar 23, 2023

  1. feat: add error logging in validator 

    used logging.Logger interface to
add error logging in validator
interceptor

addition: grpc-ecosystem#494
    @rohanraj7316
    rohanraj7316 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    3006ed6 View commit details
    Browse the repository at this point in the history

  2. feat: update interceptor implementation 

    made fast fail and logger as optional args
addition to that instead of providing values
dynamically at the time of initialization made
it more dynamic
    @rohanraj7316
    rohanraj7316 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    035f67b View commit details
    Browse the repository at this point in the history

  3. fix: update options args 

    updated args based on review
    @rohanraj7316
    rohanraj7316 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    233742c View commit details
    Browse the repository at this point in the history

  4. refactor: update validate func 

    restructured if statement  in-order to make code execution based on shouldFailFast flag more relevant.
    @rohanraj7316
    rohanraj7316 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4adb59e View commit details
    Browse the repository at this point in the history

  5. refactor: shifted interceptors into new file 

    restructured code in order to separate the
concern. ie: in terms of code struct and testcases wise.
    @rohanraj7316
    rohanraj7316 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    eb166eb View commit details
    Browse the repository at this point in the history

  6. test: updated the testcases 

    modified testcases based on the current modifications made in the code base.
    @rohanraj7316
    rohanraj7316 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    09bcdb6 View commit details
    Browse the repository at this point in the history

  7. fix: add copyright headers

    @rohanraj7316
    rohanraj7316 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    5398fb7 View commit details
    Browse the repository at this point in the history

  8. fix: update comment and code 

    updated code based on reviews
    @rohanraj7316
    rohanraj7316 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    5789ad1 View commit details
    Browse the repository at this point in the history