add support to trace on grpc_logrus.DefaultMessageProducer #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This reverts commit 10f2e4c.
johanbrandhorst
approved these changes
Mar 28, 2023
|
Thanks for this! Can you check if v2 also suffers from this bug? |
|
Hello the branch v2 seems heavily different on this part, but I will try to check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today if I use the option
grpc_logrus.WithLevelsand set one or more codes to be logged onlogrus.TraceLevelI can't see the messages.The root cause is
grpc_logrus.DefaultMessageProducerthat ignores TraceLevelpossible workaround: use
grpc_logrus.WithMessageProducerto set a callback that can hand Tracethis PR closes #546 546