Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor code cleanups #586

Merged
merged 2 commits into from Jun 2, 2023
Merged

Minor code cleanups #586

merged 2 commits into from Jun 2, 2023

Conversation

ash2k
Copy link
Contributor

@ash2k ash2k commented May 26, 2023

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Use strings.Cut() as it's more readable and doesn't allocate a slice.
  • Replace Errorf() with Error() where no formatting is being done.

Verification

Unit tests.

johanbrandhorst
johanbrandhorst reviewed May 29, 2023
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to fix the lint warning at the same time :)?

interceptors/ratelimit/ratelimit.go Outdated Show resolved Hide resolved
johanbrandhorst
johanbrandhorst requested changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Sorry I just realized this is targeted at the v2 branch, but we've merged v2 into main so please target this at main.

@ash2k ash2k changed the base branch from v2 to main June 2, 2023 09:22
@ash2k
Copy link
Contributor Author

ash2k commented Jun 2, 2023

Looks like the CLA check is not working correctly when branch is pushed to with a new base commit...

@johanbrandhorst johanbrandhorst merged commit bfde808 into grpc-ecosystem:main Jun 2, 2023
5 of 6 checks passed
@johanbrandhorst
Copy link
Collaborator

Thank you!

@ash2k ash2k deleted the cleanups branch June 3, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ash2k @johanbrandhorst