This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
More golint cleanups #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes to code at little more idiomatic and fixes: server_metrics.go:140:6: func streamRpcType should be streamRPCType server_test.go:97:6: range var testId should be testID
This fixes: metric_options.go:7:6: exported type CounterOption should have comment or be unexported metric_options.go:18:1: exported function WithConstLabels should have comment or be unexported metric_options.go:24:6: exported type HistogramOption should have comment or be unexported metric_options.go:31:1: exported function WithHistogramConstLabels should have comment or be unexported
|
BTW: This is the code: type grpcType string
const (
Unary grpcType = "unary"
ClientStream grpcType = "client_stream"
ServerStream grpcType = "server_stream"
BidiStream grpcType = "bidi_stream"
)Is it intentional that these consts are exported (the type |
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 78.59% 78.59%
=======================================
Files 8 8
Lines 271 271
=======================================
Hits 213 213
Misses 49 49
Partials 9 9
Continue to review full report at Codecov.
|
Closed
|
lgtm |
|
changing whether they are exported would be a breaking change, which we can't do in v1.2 generally though it would be good to not export anything unnecessary 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review.