fix SendHeader/SetTrailer when using grpc-gateway standalone server (#…

…1639) * add ServerTransportStream in context for local gateway handlers * regenerate files * fix lint * fix bazel test * fix after review
grpc-ecosystem · Sep 3, 2020 · 40c9a89 · 40c9a89
1 parent 98d24a7
commit 40c9a89
Show file tree

Hide file tree

Showing 17 changed files with 331 additions and 12 deletions.
diff --git a/examples/internal/helloworld/BUILD.bazel b/examples/internal/helloworld/BUILD.bazel
@@ -35,6 +35,7 @@ go_library(
         "@org_golang_google_grpc//:go_default_library",
         "@org_golang_google_grpc//codes:go_default_library",
         "@org_golang_google_grpc//grpclog:go_default_library",
+        "@org_golang_google_grpc//metadata:go_default_library",
         "@org_golang_google_grpc//status:go_default_library",
     ],
 )
diff --git a/examples/internal/helloworld/helloworld.pb.gw.go b/examples/internal/helloworld/helloworld.pb.gw.go
diff --git a/examples/internal/integration/integration_test.go b/examples/internal/integration/integration_test.go
@@ -46,6 +46,8 @@ func TestEcho(t *testing.T) {
 	testEchoOneof1(t, 8088, "application/json")
 	testEchoOneof2(t, 8088, "application/json")
 	testEchoBody(t, 8088)
+	// Use SendHeader/SetTrailer without gRPC server https://github.com/grpc-ecosystem/grpc-gateway/issues/517#issuecomment-684625645
+	testEchoBody(t, 8089)
 }
 
 func TestForwardResponseOption(t *testing.T) {

diff --git a/examples/internal/proto/examplepb/BUILD.bazel b/examples/internal/proto/examplepb/BUILD.bazel
@@ -85,6 +85,7 @@ go_library(
         "@org_golang_google_grpc//:go_default_library",
         "@org_golang_google_grpc//codes:go_default_library",
         "@org_golang_google_grpc//grpclog:go_default_library",
+        "@org_golang_google_grpc//metadata:go_default_library",
         "@org_golang_google_grpc//status:go_default_library",
     ],
 )