Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference not imported properly #1190

Closed
sgtsquiggs opened this issue Mar 27, 2020 · 8 comments
Closed

Reference not imported properly #1190

sgtsquiggs opened this issue Mar 27, 2020 · 8 comments

Comments

@sgtsquiggs
Copy link
Contributor

Example project here: https://github.com/sgtsquiggs/grpc-gateway-bug

This is the offending line: https://github.com/sgtsquiggs/grpc-gateway-bug/blob/master/genout/gate/proto/gate.pb.gw.go#L52

RateType_value should be proto_0.RateType_value

@stale
Copy link

stale bot commented May 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 26, 2020
@stale stale bot closed this as completed Jun 2, 2020
@sgtsquiggs
Copy link
Contributor Author

This should be reopened

@sgtsquiggs
Copy link
Contributor Author

Reproduced this again w/o gogo: https://github.com/sgtsquiggs/grpc_gateway_bug

@stale stale bot removed the wontfix label Jun 10, 2020
@johanbrandhorst
Copy link
Collaborator

@johanbrandhorst
Copy link
Collaborator

I think the error is probably on this line: https://github.com/grpc-ecosystem/grpc-gateway/blob/master/protoc-gen-grpc-gateway/internal/gengateway/template.go#L365. Would you be interested in submitting a PR to fix this? It should be quite easy for you to reproduce with your example.

@sgtsquiggs
Copy link
Contributor Author

I believe I fixed this here: #1203 (comment)

@johanbrandhorst
Copy link
Collaborator

Closing as dupe (though this one is older)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants