Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-swagger: Update internal mapping for boolean type #1466

Merged
merged 1 commit into from Jun 17, 2020

Conversation

ozraza
Copy link
Contributor

@ozraza ozraza commented Jun 17, 2020

Making boolean type consistent with OAS spec.

References to other Issues or PRs

Fixes #1463

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

Removed format field since it is not applicable to boolean type.

Other comments

N/A

@ozraza ozraza force-pushed the oas-1463-ozr branch 4 times, most recently from 694a29c to d0dbeda Compare June 17, 2020 02:53
@ozraza ozraza changed the title protoc-gen-swagger: Update internal mapping for boolean types protoc-gen-swagger: Update internal mapping for boolean type Jun 17, 2020
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your contribution!

@johanbrandhorst johanbrandhorst merged commit d8373da into grpc-ecosystem:master Jun 17, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution! Could you please cherry pick this fix against the v2 branch too? Thanks!

@ozraza
Copy link
Contributor Author

ozraza commented Jun 18, 2020

@johanbrandhorst Fix has been cherry picked against the v2 branch.

#1470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean type should not have a format (OAS)
3 participants