Standardize way GitHub is written in CONTRIBUTING.md #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
approved these changes
Jun 23, 2020
|
Thanks for your contribution! Could you cherry-pick this against v2 please? |
|
Sure! |
dufcrule
added a commit
to dufcrule/grpc-gateway
that referenced
this pull request
Jun 24, 2020
|
I've cherry-picked against v2 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the way GitHub is written to be consistent in the document and make sure the standard format (GitHub) is used.
Also removed an exclamation mark from a section heading and placed it in the text. Trailing punctuation in headings is generally not recommended in Markdown as headings are not meant to be full sentences. See: https://cirosantilli.com/markdown-style-guide/#punctuation-at-the-end-of-headers