Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate unbound methods #1652

Merged
merged 15 commits into from
Sep 17, 2020
Merged

Generate unbound methods #1652

merged 15 commits into from
Sep 17, 2020

Commits on Sep 8, 2020

  1. Adds generate_unbound_methods parameter. 

    This will also warn the user when they use the new option with the existing `warn_on_unbound_methods`
    @plaflamme
    plaflamme committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    6b671e3 View commit details
    Browse the repository at this point in the history

  2. Handle generate unbound methods option. 

    This adds the necessary code to handle the new `generate_unbound_methods` option.
The strategy used is to generate default options when the service method has no option and the flag is enabled.
It also adds a simple test.
    @plaflamme
    plaflamme committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    2f7511a View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Adds reference to gRPC HTTP/2 mapping.

    @plaflamme
    plaflamme committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    90e3cb7 View commit details
    Browse the repository at this point in the history

  2. Adds similar option to gen-swagger.

    @plaflamme
    plaflamme committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    237f09a View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Adds example for generate_unbounud_methods parameter.

    @plaflamme
    plaflamme committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    5339757 View commit details
    Browse the repository at this point in the history

  2. Adds resulting generated examples.

    @plaflamme
    plaflamme committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    498c5a4 View commit details
    Browse the repository at this point in the history

  3. Adds missing bazel build updates.

    @plaflamme
    plaflamme committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    677ce07 View commit details
    Browse the repository at this point in the history

  4. Adds missing BUILD file.

    @plaflamme
    plaflamme committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    1817bc8 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Simplify .gitignore files.

    @plaflamme
    plaflamme committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    4dce1f4 View commit details
    Browse the repository at this point in the history

  2. TIDY: fixup comments.

    @plaflamme
    plaflamme committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    b5706a8 View commit details
    Browse the repository at this point in the history

  3. Update generated files with new comments.

    @plaflamme
    plaflamme committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    598abe5 View commit details
    Browse the repository at this point in the history

  4. Adds documentation for generate_unbound_methods parameter.

    @plaflamme
    plaflamme committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    aaf2c61 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Adds documentation for generate_unbound_methods to README.

    @plaflamme
    plaflamme committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    ae6ba87 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. Apply suggestions from code review 

    `protoc` invocation example cleanup

Co-authored-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
    @plaflamme @johanbrandhorst
    plaflamme and johanbrandhorst committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    81c4885 View commit details
    Browse the repository at this point in the history

  2. Some markdown tidyness, additional protoc invocation documentation.

    @plaflamme
    plaflamme committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    3249fb0 View commit details
    Browse the repository at this point in the history