Change FieldMask OpenAPI type to string.

[zoido]

References to other Issues or PRs

RESOLVES #1816

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

• sets type for FieldMask to string
• adjust test expectations accordingly
• update examples generated code accordingly
• updates patch.md doc to contains the corect format for the FieldMask in the example
  • also changes the case to smallCamel that is the what the Marshaler accepts

[johanbrandhorst]

Hi! Thanks for your contribution, could you confirm that this works when using it with the generated swagger file? Thanks!

[johanbrandhorst]

Related to #1816

[vtolstov]

Very needed feature сб, 14 нояб. 2020 г., 14:41 Johan Brandhorst-Satzkorn < notifications@github.com>:

…

Related to #1816 <#1816> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1820 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADVQG6CUUYLPPON5WDWMYLSPZUGTANCNFSM4TU5VKZA> .

[codecov-io]

Codecov Report

Merging #1820 (3d984a8) into master (1f6e7b0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1820   +/-   ##
=======================================
  Coverage   57.32%   57.32%           
=======================================
  Files          34       34           
  Lines        3616     3616           
=======================================
  Hits         2073     2073           
  Misses       1282     1282           
  Partials      261      261           

Impacted Files	Coverage Δ
...otoc-gen-openapiv2/internal/genopenapi/template.go	58.68% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f6e7b0...3d984a8. Read the comment docs.

[johanbrandhorst]

Hi! This looks fine, could you just confirm that this fixes your issue before I merge it?

[zoido]

@johanbrandhorst Hi. It fixes it for us. Would you recommend the place where to include some kind of test to make sure it's covered?

I have also spotted that patch.md doc contains the example that seems to use even older format. I'd like also adjust test that before I mark this as ready for review.

[johanbrandhorst]

I don't think we ever actually encourage the user to specify a field mask, we automatically create the field mask from input JSON when possible, so the input format has never been tested. If you want to add a test for this explicit specification, it'd make sense to add it to the integration tests in https://github.com/grpc-ecosystem/grpc-gateway/blob/master/examples/internal/integration/integration_test.go#L801. Looks like we rely on the marshaler, maybe a new test which does it explicitly would make sense.

[zoido]

@johanbrandhorst Checked and updated the patch.md. PTAL.

[johanbrandhorst]

Small question on the new docs.

[johanbrandhorst]

Thanks for your contribution!