Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing unknown fields to be dropped instead of returning error from… #208

Merged
merged 2 commits into from
Aug 8, 2016

Conversation

sriniven
Copy link

@sriniven sriniven commented Aug 4, 2016

… grpc gateway

@yugui
Copy link
Member

yugui commented Aug 4, 2016

@sriniven
Thank you for fixing the issue.

  • Could you also fix jsonpb.UnmarshalNext in decodeNonProtoField?
  • github is failing to check if you have signed a CLA.
    I have asked grpc team about this issue. But could you sign the CLA if you have not yet?

@sriniven
Copy link
Author

sriniven commented Aug 4, 2016

Thanks for the quick response, Yugui.

I have fixed the decodeNonProtoField also.

And I signed the CLA, but somehow it is not updating on github. I am able
to see it in https://cla.developers.google.com/clas
AgreementNameDate SignedManage
Google Individual CLA
https://cla.developers.google.com/about/google-individual Srinivasan
Venkatachary Aug 03, 2016 23:14 PDT Edit Contact Information
https://cla.developers.google.com/clas/edit?id=107488552707523979645&kind=KIND_INDIVIDUAL&domain=DOMAIN_GOOGLE

On Thu, Aug 4, 2016 at 6:08 AM, Yuki Yugui Sonoda notifications@github.com
wrote:

@sriniven https://github.com/sriniven
Thank you for fixing the issue.

  • Could you also fix jsonpb.UnmarshalNext in decodeNonProtoField?
  • github is failing to check if you have signed a CLA
    https://cla.developers.google.com/clas. I have asked grpc team about
    this issue. But could you sign the CLA if you have not yet?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#208 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2FiNQYN46IPx3Bk9uJFqJd5S3uvurJks5qceRcgaJpZM4JcXdN
.

@zinuga
Copy link

zinuga commented Aug 4, 2016

I checked and it shows @sriniven has signed cla

@yugui yugui merged commit ccd4e6b into grpc-ecosystem:master Aug 8, 2016
@yugui
Copy link
Member

yugui commented Aug 8, 2016

LGTM.
@sriniven Thank you for your contribution.
@zinuga Thank you for your help.

@sriniven
Copy link
Author

sriniven commented Aug 8, 2016

Awesome, thanks Yugui.

On Sun, Aug 7, 2016 at 11:56 PM, Yuki Yugui Sonoda <notifications@github.com

wrote:

Merged #208 #208.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#208 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2FiEgJlFicjYBK0MB7UzkpFrKn4cnxks5qdtMhgaJpZM4JcXdN
.

@tamalsaha tamalsaha mentioned this pull request Mar 30, 2017
1 task
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
Allowing unknown fields to be dropped instead of returning error from…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants