Docs - Add section about how HTTP maps to gRPC #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achew22
requested changes
Sep 30, 2016
| @@ -220,6 +220,14 @@ But patch is welcome. | |||
| * Encoding request/response body in XML | |||
| * True bi-directional streaming. (Probably impossible?) | |||
|
|
|||
| # Mapping gRPC to HTTP | |||
|
|
|||
| * [gRPC to HTTP header code mappings](https://github.com/grpc-ecosystem/grpc-gateway/blob/master/runtime/errors.go#L15) | |||
There was a problem hiding this comment.
It isn't really a "header code" it is a http status code.
| # Mapping gRPC to HTTP | ||
|
|
||
| * [gRPC to HTTP header code mappings](https://github.com/grpc-ecosystem/grpc-gateway/blob/master/runtime/errors.go#L15) | ||
| * HTTP request source IP is added as `X-Forwarded-For` gRPC metadata |
There was a problem hiding this comment.
It is added as a gRPC header
achew22
approved these changes
Oct 1, 2016
|
This looks good to me. @yugui do you know what's up with the cla bot? |
|
@achew22 I have a CLA on file, if you can verify through my Github username. |
|
LGTM. Thank you for your contribution. |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
* Docs - Add section about how HTTP maps to gRPC * README - Incorporate code review feedback Feedback from @achew22 for github.com/grpc-ecosystem#227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.