Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-swagger/genswagger: add PATCH support #228

Closed
wants to merge 5 commits into from
Closed

protoc-gen-swagger/genswagger: add PATCH support #228

wants to merge 5 commits into from

Conversation

ericlagergren
Copy link

@ericlagergren ericlagergren commented Oct 4, 2016

Fixes: #211

@ericlagergren
Copy link
Author

CLA should be good to go (https://golang.org/CONTRIBUTORS#L340)

@achew22
Copy link
Collaborator

achew22 commented Oct 5, 2016

Thanks so much for sending your PR in. Do you think you could update the example protos to include a "PATCH" and regenerate the generated files? I think "make examples" is all you need to do for that.

Thanks! I look forward to having patch support.

@ericlagergren
Copy link
Author

Yeah I think I can do it tomorrow, feel free to ping me if I forget 😄

@yugui
Copy link
Member

yugui commented Oct 25, 2016

@ericlagergren ping 😉

@tmc
Copy link
Collaborator

tmc commented Nov 5, 2016

@ericlagergren thank you for your contribution - can you rebase and re-gen examples for this please?

@tmc
Copy link
Collaborator

tmc commented Nov 7, 2016

@ericlagergren I think you are running a different version of swagger-codegen -- this project currently relies on 2.1.6

@ericlagergren
Copy link
Author

I think you're right. I used the latest swagger-codegen release, whatever version it is. I thought the massive amount of changes looked weird, but I didn't have time to throughly debug it today.

I'll revert and re-run it with 2.16 either tonight or tomorrow morning.

@tmc
Copy link
Collaborator

tmc commented Nov 15, 2016

ping @ericlagergren

@tmc tmc mentioned this pull request Nov 20, 2016
yugui pushed a commit that referenced this pull request Nov 28, 2016
@yugui yugui closed this Nov 28, 2016
@tamalsaha tamalsaha mentioned this pull request Mar 30, 2017
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants