Added support for Timestamp in URL. #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johansja thank you for your contribution. This change looks good -- can you sign your Google CLA? Are there other values than "null" that need to be special cased? NaN |
|
I thought I have signed one before? If not, can you point me to where I should sign for it? Not sure if we need to handle the other null value though. The code is actually referred from the protobuf project. |
|
@johansja looks like googlebot just hadn't reported correctly -- can you resolve the query_test.go conflict? I'd love to see this land. |
|
@johansja can you try commenting to ping googlebot? |
|
Wake up, googlebot. |
|
I want to use this so I'm going to squash and merge. Thanks for your contribution @johansja |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
Add support for google.protobuf.Timestamp in URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.