write query parameters to swagger definition

[t-yuki]

It takes over from #199

[t-yuki]

map values is hard to process in query parameter. (some WAF handles it in map_value[KEY]=VALUE)
should we ignore it initially?

[achew22]

Should the default be ["ZERO"]? or maybe []?

[t-yuki]

Agree. I unset default field.
Note that, swagger petstore example has the array parameter with default field.
I wonder what it means but in protobuf, it should be nil.

"parameters":[{"name":"status","in":"query","description":"Status values that need to be considered for filter","required":true,"type":"array","items":{"type":"string","enum":["available","pending","sold"],"default":"available"},"collectionFormat":"multi"}],

[achew22]

This looks good to me. Thanks so much for contributing. Can you comment to kick the CLA bot into gear?

There is a chance that the CLA bot can't handle the case where you're committing on top of someone else's work. If that happens, I will manually merge you from the CLI.

[t-yuki]

ping @googlebot

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[doroginin]

+1, We need this feature, merge it please!

[achew22]

@rgarcia, can you confirm a couple of things for me please before I merge this?

1. You are the author of the commits that @t-yuki extended upon
2. You're comfortable with the additional changes made
3. To the best of your knowledge you've signed the CLA (write query parameters to swagger definition #199 implies yes but I wanna double check)

[rgarcia]

@achew22 1. yes 2. yes 3. yes 😄

[achew22]

Huh, foiled by the CLI bot. Even on the command line I can't push past this. @yugui can we change the CLAbot to being advisory or non-blocking or whatever github calls it?

[t-yuki]

Should I re-push without rebase to avoid CLA bot fail?

[achew22]

We could be really tricky and merge the other PR then this one quickly as not to break anyone, hopefully. I just sent an email to yugui (not @'d on purpose cause I just sent her an email) about modifying the submission rules. Let's see how that plays out. Meet back here in 24 hours?

[yugui]

@achew22 I don't think we can make the bot advisory. But I have granted admin rights of this project to you and @tmc. So now you can ignore the status check at your own risk.