Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug.ReadBuildInfo for retrieving plugin version #3023

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protoc-gen-grpc-gateway/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func main() {
defer glog.Flush()

if *versionFlag {
fmt.Printf("Version %v, commit %v, built at %v\n", version, commit, date)
fmt.Printf("Version %v, commit %v, built at %v\n", readVersion(), commit, date)
os.Exit(0)
}

Expand Down
13 changes: 13 additions & 0 deletions protoc-gen-grpc-gateway/main_go1.18.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//go:build go1.18

package main

import "runtime/debug"

func readVersion() string {
v, ok := debug.ReadBuildInfo()
if !ok {
return version
}
return v.Main.Version
}
7 changes: 7 additions & 0 deletions protoc-gen-grpc-gateway/main_go_less1.18.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
//go:build !go1.18

package main

func readVersion() string {
return version
}
2 changes: 1 addition & 1 deletion protoc-gen-openapiv2/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func main() {
defer glog.Flush()

if *versionFlag {
fmt.Printf("Version %v, commit %v, built at %v\n", version, commit, date)
fmt.Printf("Version %v, commit %v, built at %v\n", readVersion(), commit, date)
os.Exit(0)
}

Expand Down
13 changes: 13 additions & 0 deletions protoc-gen-openapiv2/main_go1.18.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//go:build go1.18

package main

import "runtime/debug"

func readVersion() string {
v, ok := debug.ReadBuildInfo()
if !ok {
return version
}
return v.Main.Version
}
7 changes: 7 additions & 0 deletions protoc-gen-openapiv2/main_go_less1.18.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
//go:build !go1.18

package main

func readVersion() string {
return version
}