Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop using the deprecated field archives.replacements #3436

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Jul 28, 2023

References to other Issues or PRs

Fixes #3435

Have you read the Contributing Guidelines?

Yes.

Brief description of what is fixed or changed

I could reproduce the issue on may laptop.

$ goreleaser --version
  ____       ____      _
 / ___| ___ |  _ \ ___| | ___  __ _ ___  ___ _ __
| |  _ / _ \| |_) / _ \ |/ _ \/ _` / __|/ _ \ '__|
| |_| | (_) |  _ <  __/ |  __/ (_| \__ \  __/ |
 \____|\___/|_| \_\___|_|\___|\__,_|___/\___|_|
goreleaser: Deliver Go Binaries as fast and easily as possible
https://goreleaser.com

GitVersion:    1.19.2
GitCommit:     b95fd394866efeb147769b49a469f88186606177
GitTreeState:  false
BuildDate:     2023-07-07T13:32:08Z
BuiltBy:       goreleaser
GoVersion:     go1.20.5
Compiler:      gc
ModuleSum:     h1:m24wCy0UzBTGO3zqezAxcoA87RBySRRL0dyJjiNfdjQ=
Platform:      darwin/arm64
$ goreleaser release --rm-dist --snapshot
Flag --rm-dist has been deprecated, please use --clean instead
  • starting release...
  • loading config file                              file=.goreleaser.yml
  ⨯ release failed after 0s                  error=yaml: unmarshal errors:
  line 29: field replacements not found in type config.Archive

And I confirmed this pull request would resolve the issue.

$ goreleaser release --rm-dist --snapshot
Flag --rm-dist has been deprecated, please use --clean instead
  • starting release...
  • loading config file                              file=.goreleaser.yml
    • DEPRECATED: --rm-dist was deprecated in favor of --clean, check https://goreleaser.com/deprecations#-rm-dist for more details
  • loading environment variables
  • getting and validating git state
    • building...                                    commit=79d4a7b3ef9729bc90b818bf19d87101fb91b9da latest tag=v2.16.1
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
    • took: 1s
  • snapshotting
    • building snapshot...                           version=2.16.1-SNAPSHOT-79d4a7b3
  • checking distribution directory
  • loading go mod information
    • took: 1s
  • build prerequisites
  • writing effective config file
    • writing                                        config=_output/config.yaml
  • building binaries
    • building                                       binary=_output/protoc-gen-openapiv2_darwin_arm64/protoc-gen-openapiv2
    • building                                       binary=_output/protoc-gen-grpc-gateway_linux_amd64_v1/protoc-gen-grpc-gateway
    • building                                       binary=_output/protoc-gen-grpc-gateway_windows_amd64_v1/protoc-gen-grpc-gateway.exe
    • building                                       binary=_output/protoc-gen-openapiv2_linux_amd64_v1/protoc-gen-openapiv2
    • building                                       binary=_output/protoc-gen-grpc-gateway_windows_arm64/protoc-gen-grpc-gateway.exe
    • building                                       binary=_output/protoc-gen-openapiv2_linux_arm64/protoc-gen-openapiv2
    • building                                       binary=_output/protoc-gen-grpc-gateway_linux_arm64/protoc-gen-grpc-gateway
    • building                                       binary=_output/protoc-gen-grpc-gateway_darwin_arm64/protoc-gen-grpc-gateway
    • building                                       binary=_output/protoc-gen-grpc-gateway_darwin_amd64_v1/protoc-gen-grpc-gateway
    • building                                       binary=_output/protoc-gen-openapiv2_darwin_amd64_v1/protoc-gen-openapiv2
    • building                                       binary=_output/protoc-gen-openapiv2_windows_amd64_v1/protoc-gen-openapiv2.exe
    • building                                       binary=_output/protoc-gen-openapiv2_windows_arm64/protoc-gen-openapiv2.exe
    • took: 25s
  • archives
    • skip archiving                                 binary=protoc-gen-grpc-gateway.exe name=protoc-gen-grpc-gateway-v2.16.1-windows-arm64.exe
    • skip archiving                                 binary=protoc-gen-grpc-gateway name=protoc-gen-grpc-gateway-v2.16.1-linux-arm64
    • skip archiving                                 binary=protoc-gen-openapiv2 name=protoc-gen-openapiv2-v2.16.1-linux-arm64
    • skip archiving                                 binary=protoc-gen-grpc-gateway name=protoc-gen-grpc-gateway-v2.16.1-darwin-arm64
    • skip archiving                                 binary=protoc-gen-openapiv2 name=protoc-gen-openapiv2-v2.16.1-darwin-arm64
    • skip archiving                                 binary=protoc-gen-openapiv2.exe name=protoc-gen-openapiv2-v2.16.1-windows-arm64.exe
    • skip archiving                                 binary=protoc-gen-grpc-gateway.exe name=protoc-gen-grpc-gateway-v2.16.1-windows-x86_64.exe
    • skip archiving                                 binary=protoc-gen-openapiv2.exe name=protoc-gen-openapiv2-v2.16.1-windows-x86_64.exe
    • skip archiving                                 binary=protoc-gen-grpc-gateway name=protoc-gen-grpc-gateway-v2.16.1-darwin-x86_64
    • skip archiving                                 binary=protoc-gen-openapiv2 name=protoc-gen-openapiv2-v2.16.1-darwin-x86_64
    • skip archiving                                 binary=protoc-gen-grpc-gateway name=protoc-gen-grpc-gateway-v2.16.1-linux-x86_64
    • skip archiving                                 binary=protoc-gen-openapiv2 name=protoc-gen-openapiv2-v2.16.1-linux-x86_64
  • calculating checksums
  • storing release metadata
    • writing                                        file=_output/artifacts.json
    • writing                                        file=_output/metadata.json
  • you are using deprecated options, check the output above for details
  • release succeeded after 26s
  • thanks for using goreleaser!

Other comments

@johanbrandhorst
Copy link
Collaborator

Thank you for the speedy fixes :)

@johanbrandhorst johanbrandhorst merged commit 8fdc8ae into grpc-ecosystem:main Jul 28, 2023
34 of 35 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the chore/fix-goreleaser-config branch July 28, 2023 20:24
michaelkedar pushed a commit to google/osv.dev that referenced this pull request Sep 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/grpc-ecosystem/grpc-gateway/v2](https://togithub.com/grpc-ecosystem/grpc-gateway)
| require | minor | `v2.16.0` -> `v2.18.0` |
|
[google.golang.org/protobuf](https://togithub.com/protocolbuffers/protobuf-go)
| require | minor | `v1.30.0` -> `v1.31.0` |
|  |  | lockFileMaintenance | All locks refreshed |
| [jekyll-feed](https://togithub.com/jekyll/jekyll-feed) | | minor |
`0.15.1` -> `0.17.0` |

---

### Release Notes

<details>
<summary>grpc-ecosystem/grpc-gateway
(github.com/grpc-ecosystem/grpc-gateway/v2)</summary>

###
[`v2.18.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.18.0)

[Compare
Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.17.1...v2.18.0)

#### What's Changed

- Enable a few more golangci-lint linters by
[@&#8203;pkwarren](https://togithub.com/pkwarren) in
[grpc-ecosystem/grpc-gateway#3546
- Add .golangci.yml config by
[@&#8203;pkwarren](https://togithub.com/pkwarren) in
[grpc-ecosystem/grpc-gateway#3548
- Fix: path item objects become block scalars
\[[#&#8203;3557](https://togithub.com/grpc-ecosystem/grpc-gateway/issues/3557)]
by [@&#8203;qawatake](https://togithub.com/qawatake) in
[grpc-ecosystem/grpc-gateway#3566
- Add remove_internal_comments option by
[@&#8203;same-id](https://togithub.com/same-id) in
[grpc-ecosystem/grpc-gateway#3560

#### New Contributors

- [@&#8203;benjx1990](https://togithub.com/benjx1990) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3552
- [@&#8203;qawatake](https://togithub.com/qawatake) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3566

**Full Changelog**:
grpc-ecosystem/grpc-gateway@v2.17.1...v2.18.0

###
[`v2.17.1`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.17.1)

[Compare
Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.17.0...v2.17.1)

#### What's Changed

- genopenapi: set source code info explicitly by
[@&#8203;johanbrandhorst](https://togithub.com/johanbrandhorst) in
[grpc-ecosystem/grpc-gateway#3544
- Record the filename of files that are missing SourceCodeInfo by
[@&#8203;ebilling](https://togithub.com/ebilling) in
[grpc-ecosystem/grpc-gateway#3545

#### New Contributors

- [@&#8203;ebilling](https://togithub.com/ebilling) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3545

**Full Changelog**:
grpc-ecosystem/grpc-gateway@v2.17.0...v2.17.1

###
[`v2.17.0`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.17.0)

[Compare
Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.16.2...v2.17.0)

#### What's Changed

- Fix renovate.yml overwriting .bazelrc by
[@&#8203;adambabik](https://togithub.com/adambabik) in
[grpc-ecosystem/grpc-gateway#3451
- fix: successful typo by
[@&#8203;testwill](https://togithub.com/testwill) in
[grpc-ecosystem/grpc-gateway#3510
- Update example buf.gen.yaml by
[@&#8203;pkwarren](https://togithub.com/pkwarren) in
[grpc-ecosystem/grpc-gateway#3522
- fix(deps): replace all uses of golang/protobuf/protobuf by
[@&#8203;aimuz](https://togithub.com/aimuz) in
[grpc-ecosystem/grpc-gateway#3516
- Feature/issue 3051 swagger preserve rpc order by
[@&#8203;CemGurhan](https://togithub.com/CemGurhan) in
[grpc-ecosystem/grpc-gateway#3500

#### New Contributors

- [@&#8203;testwill](https://togithub.com/testwill) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3510
- [@&#8203;pkwarren](https://togithub.com/pkwarren) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3522
- [@&#8203;aimuz](https://togithub.com/aimuz) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3516
- [@&#8203;CemGurhan](https://togithub.com/CemGurhan) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3500

**Full Changelog**:
grpc-ecosystem/grpc-gateway@v2.16.2...v2.17.0

###
[`v2.16.2`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.16.2)

[Compare
Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.16.1...v2.16.2)

#### What's Changed

- chore: replace the Goreleaser's deprecated option `--rm-dist` to
`--clean` by
[@&#8203;suzuki-shunsuke](https://togithub.com/suzuki-shunsuke) in
[grpc-ecosystem/grpc-gateway#3438
- chore: stop using the deprecated field `archives.replacements` by
[@&#8203;suzuki-shunsuke](https://togithub.com/suzuki-shunsuke) in
[grpc-ecosystem/grpc-gateway#3436

#### New Contributors

- [@&#8203;suzuki-shunsuke](https://togithub.com/suzuki-shunsuke) made
their first contribution in
[grpc-ecosystem/grpc-gateway#3438

**Full Changelog**:
grpc-ecosystem/grpc-gateway@v2.16.1...v2.16.2

###
[`v2.16.1`](https://togithub.com/grpc-ecosystem/grpc-gateway/releases/tag/v2.16.1)

[Compare
Source](https://togithub.com/grpc-ecosystem/grpc-gateway/compare/v2.16.0...v2.16.1)

#### What's Changed

- Rename LICENSE.txt to LICENSE by
[@&#8203;pgmitche](https://togithub.com/pgmitche) in
[grpc-ecosystem/grpc-gateway#3345
- feat: message supports enum field option for query params by
[@&#8203;zhb127](https://togithub.com/zhb127) in
[grpc-ecosystem/grpc-gateway#3352
- remove glog from a bunch of spots by
[@&#8203;kn100](https://togithub.com/kn100) in
[grpc-ecosystem/grpc-gateway#3361
- Improve AIP support in field_configuration.path_param_name containing
by [@&#8203;same-id](https://togithub.com/same-id) in
[grpc-ecosystem/grpc-gateway#3364
- Hide comments on omitted enum default values by
[@&#8203;same-id](https://togithub.com/same-id) in
[grpc-ecosystem/grpc-gateway#3366
- fix(docs): correcting mux routing error code example by
[@&#8203;tjasko](https://togithub.com/tjasko) in
[grpc-ecosystem/grpc-gateway#3409
- Fix the place where format property in placed for repeated fields by
[@&#8203;far4599](https://togithub.com/far4599) in
[grpc-ecosystem/grpc-gateway#3410
- Handle httpbody not having data to return by
[@&#8203;achew22](https://togithub.com/achew22) in
[grpc-ecosystem/grpc-gateway#3415
- bazel: bump Bazel repositories versions by
[@&#8203;adambabik](https://togithub.com/adambabik) in
[grpc-ecosystem/grpc-gateway#3413

#### New Contributors

- [@&#8203;pgmitche](https://togithub.com/pgmitche) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3345
- [@&#8203;zhb127](https://togithub.com/zhb127) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3352
- [@&#8203;kn100](https://togithub.com/kn100) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3361
- [@&#8203;tjasko](https://togithub.com/tjasko) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3409
- [@&#8203;far4599](https://togithub.com/far4599) made their first
contribution in
[grpc-ecosystem/grpc-gateway#3410

**Full Changelog**:
grpc-ecosystem/grpc-gateway@v2.16.0...v2.16.1

</details>

<details>
<summary>protocolbuffers/protobuf-go
(google.golang.org/protobuf)</summary>

###
[`v1.31.0`](https://togithub.com/protocolbuffers/protobuf-go/releases/tag/v1.31.0)

[Compare
Source](https://togithub.com/protocolbuffers/protobuf-go/compare/v1.30.0...v1.31.0)

#### Notable changes <a name="v1.31-notable-changes"></a>

**New Features**

-   [CL/489316](https://go.dev/cl/489316): types/dynamicpb: add NewTypes
- Add a function to construct a dynamic type registry from a
protoregistry.Files
- [CL/489615](https://go.dev/cl/489615): encoding: add MarshalAppend to
protojson and prototext

**Minor performance improvements**

- [CL/491596](https://go.dev/cl/491596): encoding/protodelim: If
UnmarshalFrom gets a bufio.Reader, try to reuse its buffer instead of
creating a new one
- [CL/500695](https://go.dev/cl/500695): proto: store the size of tag to
avoid multiple calculations

**Bug fixes**

- [CL/497935](https://go.dev/cl/497935): internal/order: fix sorting of
synthetic oneofs to be deterministic
- [CL/505555](https://go.dev/cl/505555): encoding/protodelim: fix
handling of io.EOF

</details>

<details>
<summary>jekyll/jekyll-feed (jekyll-feed)</summary>

###
[`v0.17.0`](https://togithub.com/jekyll/jekyll-feed/blob/HEAD/History.markdown#0170--2022-10-14)

[Compare
Source](https://togithub.com/jekyll/jekyll-feed/compare/v0.16.0...v0.17.0)

##### Documentation

- Update CI status badge
([#&#8203;363](https://togithub.com/jekyll/jekyll-feed/issues/363))

##### Development Fixes

- Add Ruby 3.1 to the CI matrix
([#&#8203;365](https://togithub.com/jekyll/jekyll-feed/issues/365))

##### Minor Enhancements

- Allow disabling of jekyll-feed while in development
([#&#8203;370](https://togithub.com/jekyll/jekyll-feed/issues/370))

###
[`v0.16.0`](https://togithub.com/jekyll/jekyll-feed/blob/HEAD/History.markdown#0160--2022-01-03)

[Compare
Source](https://togithub.com/jekyll/jekyll-feed/compare/v0.15.1...v0.16.0)

##### Minor Enhancements

- Add support for `page.description` in front matter to become entry
`<summary>`
([#&#8203;297](https://togithub.com/jekyll/jekyll-feed/issues/297))

##### Bug Fixes

- Fold private methods into the `:render` method as local variables
([#&#8203;327](https://togithub.com/jekyll/jekyll-feed/issues/327))
- Check `post.categories` instead of `post.category`
([#&#8203;357](https://togithub.com/jekyll/jekyll-feed/issues/357))
- Switched xml_escape for `<![CDATA[]]>` for post content
([#&#8203;332](https://togithub.com/jekyll/jekyll-feed/issues/332))

##### Development Fixes

- Add Ruby 3.0 to CI
([#&#8203;337](https://togithub.com/jekyll/jekyll-feed/issues/337))
- Lock RuboCop to v1.18.x
([#&#8203;348](https://togithub.com/jekyll/jekyll-feed/issues/348))
- Add workflow to release gem via GH Action
([#&#8203;355](https://togithub.com/jekyll/jekyll-feed/issues/355))

##### Documentation

- Use `.atom` extension in documented examples since we write an Atom
feed ([#&#8203;359](https://togithub.com/jekyll/jekyll-feed/issues/359))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 6am on wednesday" in timezone
Australia/Sydney, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/google/osv.dev).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The release workflow was broken
2 participants