Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Http Close Notifier #752

Closed
wants to merge 2 commits into from
Closed

Remove Http Close Notifier #752

wants to merge 2 commits into from

Conversation

srikrsna
Copy link
Contributor

@johanbrandhorst
Copy link
Collaborator

Thanks for your PR! You'll need to regenerate the examples with make examples. Make sure you've installed the correct version of protoc and protoc-gen-go.

@johanbrandhorst
Copy link
Collaborator

At least one of the generation jobs failed, so it looks like you're not using the correct versions of protoc and protoc-gen-go to generate the examples. You'll need protoc version 3.1.0 and protoc-gen-go version 1.1.0.

@johanbrandhorst
Copy link
Collaborator

@maros7 if you want to commandeer this please open a new PR rebased on master and I will close this one. @srikrsna if you want to finish this off, please rebase on master and follow the new regeneration instructions.

@srikrsna
Copy link
Contributor Author

Apologies @johanbrandhorst I've tried to do this several times but some reason it constantly fails. I am closing this request.

@srikrsna srikrsna closed this Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants