Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove http.CloseNotifier code from Go >= 1.7 builds #795

Merged
merged 1 commit into from Nov 3, 2018
Merged

Remove http.CloseNotifier code from Go >= 1.7 builds #795

merged 1 commit into from Nov 3, 2018

Commits on Nov 3, 2018

  1. Remove http.CloseNotifier code from Go >= 1.7 builds 

    http.CloseNotifier is deprecated as of Go 1.11, with a note that "the
CloseNotifier interface predates Go's context package. New code should
use Request.Context instead."

Seeing as Request.Context has been around since 1.7, it seems likely
safe to adjust our template to omit this block whenever Request.Context
is in use.
    @SpikesDivZero
    SpikesDivZero committed Nov 3, 2018
    Copy the full SHA
    d22b116 View commit details
    Browse the repository at this point in the history