Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which test framework should we use? #115

Closed
ST-DDT opened this issue Oct 25, 2018 · 3 comments
Closed

Which test framework should we use? #115

ST-DDT opened this issue Oct 25, 2018 · 3 comments

Comments

@ST-DDT
Copy link
Collaborator

ST-DDT commented Oct 25, 2018

I thought about adding a test project that can be used to automatically test all features of this library, to ensure there are no hidden breakages if new features are added or existing features changed.

Would you prefer JUnit 4.12 based tests or are you okay with the new JUnit 5 (JUpiter) tests?

(There isn't that much of a difference, but the new version uses a different package and is slightly more flexible due to using Java 8 features)

@yidongnan
Copy link
Collaborator

I have not used junit 5 in any project. what advice do you have? If you think that JUnit 5 is OK, I think we can also try it.

@ST-DDT
Copy link
Collaborator Author

ST-DDT commented Oct 26, 2018

I like it and added a test project with JUnit 5 in https://github.com/yidongnan/grpc-spring-boot-starter/pull/113#issuecomment-433455114.

@ST-DDT
Copy link
Collaborator Author

ST-DDT commented Oct 28, 2018

I guess this issue is solved for now.

@ST-DDT ST-DDT closed this as completed Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants