Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade grpc and remove unused method #1052

Merged
merged 5 commits into from Apr 12, 2024

Conversation

Sineaggi
Copy link

@Sineaggi Sineaggi commented Feb 8, 2024

The method was removed upstream grpc/grpc-java#10744

@Sineaggi
Copy link
Author

Sineaggi commented Feb 8, 2024

Relates to #1030

ST-DDT
ST-DDT previously approved these changes Feb 8, 2024
@ST-DDT ST-DDT added this to the 3.0.0 milestone Feb 8, 2024
@ST-DDT
Copy link
Collaborator

ST-DDT commented Mar 13, 2024

Please resolve the conflicts.

@Sineaggi
Copy link
Author

Please resolve the conflicts.

Rebased

@ST-DDT
Copy link
Collaborator

ST-DDT commented Mar 13, 2024

Please remove it also from here:

@Sineaggi
Copy link
Author

@ST-DDT It is done

@Sineaggi
Copy link
Author

Good to merge?

Copy link
Collaborator

@yidongnan yidongnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yidongnan yidongnan modified the milestones: 3.0.0, 3.1.0 Apr 12, 2024
@yidongnan yidongnan merged commit 7bd1516 into grpc-ecosystem:master Apr 12, 2024
1 check passed
@Sineaggi Sineaggi deleted the upgrade-grpc branch April 12, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants