Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception if service is registered twice #392

Merged
merged 1 commit into from Jul 29, 2020
Merged

Throw exception if service is registered twice #392

merged 1 commit into from Jul 29, 2020

Conversation

ST-DDT
Copy link
Collaborator

@ST-DDT ST-DDT commented Jul 21, 2020

Implements #365
Ref: grpc/grpc-java#7125

@ST-DDT ST-DDT added the enhancement A feature request or improvement label Jul 21, 2020
@ST-DDT ST-DDT added this to the 2.10.0 milestone Jul 21, 2020
@ST-DDT ST-DDT requested a review from yidongnan July 21, 2020 19:17
@ST-DDT ST-DDT self-assigned this Jul 21, 2020
@ST-DDT ST-DDT linked an issue Jul 21, 2020 that may be closed by this pull request
Creating multiple service classes with @GrpcService annotation #365
Closed
yidongnan
yidongnan approved these changes Jul 29, 2020
View reviewed changes
Copy link
Collaborator

@yidongnan yidongnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yidongnan yidongnan merged commit 813e0d7 into master Jul 29, 2020
@yidongnan yidongnan deleted the feature/throw-on-service-duplicates branch July 29, 2020 02:52
@ST-DDT ST-DDT mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yidongnan yidongnan yidongnan approved these changes

Assignees

@ST-DDT ST-DDT

Labels
enhancement A feature request or improvement
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

Creating multiple service classes with @GrpcService annotation
2 participants
@ST-DDT @yidongnan