Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GrpcClient#interceptors bean lookup + improve examples #532

Merged
merged 3 commits into from Apr 27, 2021

Conversation

ST-DDT
Copy link
Collaborator

@ST-DDT ST-DDT commented Apr 25, 2021

Fixes #503

Due to the broken check in the GrpcClientBeanPostProcessor the GrpcClient#interceptors() property didn't work if there were at least one ClientInterceptors in the application context, but a constructor based one was intended to be created here.

@ST-DDT ST-DDT added the bug Something does not work as expected label Apr 25, 2021
@ST-DDT ST-DDT added this to the 2.12.0 milestone Apr 25, 2021
@ST-DDT ST-DDT requested a review from yidongnan April 25, 2021 21:35
@ST-DDT ST-DDT self-assigned this Apr 25, 2021
@yidongnan yidongnan merged commit c3b6aad into master Apr 27, 2021
@yidongnan yidongnan deleted the fix/client-interceptor-annotation branch April 27, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local-grpc-client/example LogGrpcInterceptor cannot be injected
2 participants