Correct tag names according to Micrometer's docs #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See. https://micrometer.io/docs/concepts#_tag_naming With the current implementation and using official prometheus exporter, we end up with label keys "methodType" and "statusCode". These labels don't follow the snake_case naming convention that prometheus follows for labels. Using dot for word separator makes micrometer automatically convert label names to snake case correctly for different exporters out of the box.
rubda
approved these changes
Mar 21, 2022
|
This looks good to me. |
ST-DDT
approved these changes
Mar 21, 2022
|
Opened the PR against micrometer: micrometer-metrics/micrometer#3088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See. https://micrometer.io/docs/concepts#_tag_naming
With the current implementation and using official prometheus exporter,
we end up with label names
methodTypeandstatusCode. These labelsdon't follow the snake_case naming convention that prometheus follows
for labels.
Using dot for word separator makes micrometer automatically convert
label names to snake case out of the box.
See. https://github.com/micrometer-metrics/micrometer/blob/main/implementations/micrometer-registry-prometheus/src/main/java/io/micrometer/prometheus/PrometheusNamingConvention.java