Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubernetes config doc #683

Merged
merged 1 commit into from May 13, 2022
Merged

Fix kubernetes config doc #683

merged 1 commit into from May 13, 2022

Conversation

coltstrgj
Copy link

This member variable is called "client" (not "clients") so spring will fail to populate the values as documented.

Locally I tried:

grpc:
  client:
    my-server:
      address: dns:///my-server-using-client
  clients:
    my-server:
      address: dns:///my-server-using-client-with-s

And confirmed that the address is not populated with an "s" provided.

Copy link
Collaborator

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted!

@ST-DDT ST-DDT requested a review from yidongnan May 12, 2022 21:57
@ST-DDT ST-DDT added the documentation Everything related to the documentation label May 12, 2022
@ST-DDT ST-DDT added this to the 2.14.0 milestone May 12, 2022
@yidongnan yidongnan merged commit 674273a into grpc-ecosystem:master May 13, 2022
@coltstrgj
Copy link
Author

Thanks for getting to that so fast. Nice project by the way, it's been a huge help.

@ST-DDT
Copy link
Collaborator

ST-DDT commented May 13, 2022

That is nice to hear ❤️ . Thanks again for your contribution. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Everything related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants