Support grpc-web in pure dart #287
Conversation
|
|
Support grpc-web in pure dart
Support gzip compression
Make sure connection errors are propagated
|
Is there interest in this PR? |
|
Yes, this as awesome! We need to fix the test. |
|
Cool, I wanted to know if there was interest before rewriting the tests. It's done but your Windows tests are failing because of misconfiguration. FYI, we've been using this branch on a real-world app since March 24th. |
|
The windows bots seems to work after a reboot. @nichite are you fine with merging this? |
|
Ping? I'd love to not keep maintaining a fork. |
|
This would be useful for a project I'm working on too: Related |
lib/src/shared/message.dart
Outdated
| @@ -69,8 +71,8 @@ StreamTransformer<GrpcMessage, GrpcMessage> grpcDecompressor() => | |||
| handleData: (GrpcMessage value, EventSink<GrpcMessage> sink) { | |||
| if (value is GrpcData) { | |||
| if (value.isCompressed) { | |||
| // TODO(dart-lang/grpc-dart#6): Actually handle decompression. | |||
| sink.add(GrpcData(value.data, isCompressed: false)); | |||
| final decompressedData = GZipDecoder().decodeBytes(value.data); | |||
There was a problem hiding this comment.
Can we take the decompression part out of this PR?
Even though this is awesome I am reluctant to take a dependency on package:archive.
|
@robsonmeemo , Do you have any idea what part of your PR that broke server side streaming ?. |
|
It would be very nice if this package was conditional and would just work in flutter so that code was transparent between web and everything else. |
Undo PR grpc#287 that broke grpc-web
This reverts commit c513e14. The original commit has broken streaming due to limitations of package:http.
This reverts commit c513e14. The original commit has broken streaming due to limitations of package:http.
Fixes #216