This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Added python images for grpcio 1.12.1 #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetb
reviewed
Sep 30, 2018
1.12.1/python/Dockerfile
Outdated
|
|
||
| ENV GRPC_PYTHON_VERSION 1.12.1 | ||
| RUN python -m pip install --upgrade pip | ||
| RUN pip install grpcio==${GRPC_PYTHON_VERSION} grpcio-tools==${GRPC_PYTHON_VERSION} grpcio-reflection==${GRPC_PYTHON_VERSION} grpcio-health-checking==${GRPC_PYTHON_VERSION} |
There was a problem hiding this comment.
consider separating these into separate lines for readability.
|
|
|
I chose this as we have existing dependencies on gRPC 1.12.1 across various python codebases. I'll open additional PRs for those versions if the team is comfortable in adding new versions! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.