Change Resolver.ResolveAsync to virtual (#1523)

grpc · Dec 15, 2021 · 520c574 · 520c574
1 parent d5626ab
commit 520c574
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/src/Grpc.Net.Client/Balancer/Resolver.cs b/src/Grpc.Net.Client/Balancer/Resolver.cs
@@ -173,7 +173,10 @@ private async Task ResolveNowAsync(CancellationToken cancellationToken)
         /// </summary>
         /// <param name="cancellationToken">A cancellation token.</param>
         /// <returns>A task.</returns>
-        protected abstract Task ResolveAsync(CancellationToken cancellationToken);
+        protected virtual Task ResolveAsync(CancellationToken cancellationToken)
+        {
+            return Task.CompletedTask;
+        }
 
         /// <summary>
         /// Releases the unmanaged resources used by the <see cref="LoadBalancer"/> and optionally releases

diff --git a/src/Grpc.Net.Client/Balancer/StaticResolver.cs b/src/Grpc.Net.Client/Balancer/StaticResolver.cs
@@ -53,12 +53,6 @@ protected override void OnStarted()
             // Send addresses to listener once. They will never change.
             Listener(ResolverResult.ForResult(_addresses, serviceConfig: null, serviceConfigStatus: null));
         }
-
-        /// <inheritdoc />
-        protected override Task ResolveAsync(CancellationToken cancellationToken)
-        {
-            return Task.CompletedTask;
-        }
     }
 
     /// <summary>

diff --git a/test/Grpc.Net.Client.Tests/GrpcChannelTests.cs b/test/Grpc.Net.Client.Tests/GrpcChannelTests.cs
@@ -836,11 +836,6 @@ public ChannelTestResolver(ResolverOptions options) : base(options.LoggerFactory
             }
 
             public ResolverOptions Options { get; }
-
-            protected override Task ResolveAsync(CancellationToken cancellationToken)
-            {
-                throw new NotImplementedException();
-            }
         }
 #endif