Fix repeatedly decoding base64 with large grpc-web-text request #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
approved these changes
Sep 9, 2020
| @@ -158,31 +170,57 @@ public async override ValueTask<ReadResult> ReadAsync(CancellationToken cancella | |||
| } | |||
|
|
|||
| // Limit result to complete base64 segments (multiples of 4) | |||
| var buffer = innerResult.Buffer.Slice(0, (innerResult.Buffer.Length / 4) * 4); | |||
| var newResultLength = innerResult.Buffer.Length - _currentInnerBufferRead; | |||
| var newResultValidLength = (newResultLength / 4) * 4; | |||
There was a problem hiding this comment.
Curious if bitmasking would be faster than a division and a multiplication here. Not sure if the compiler is smart enough to automatically do that. Also, I would assume the effect here would be pretty small anyways, but I was just curious.
There was a problem hiding this comment.
Anything here will be dwarfed by the calls to ReadAsync and base64 decoding.
JamesNK
force-pushed
the
jamesnk/grpcwebtext-readasync-fix
branch
from
840692c
to
db296d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large base64 encoded messages are slow to decode. Each time ReadAsync is called all the buffered data is re-decoded.
This PR changes base64 decoding to be incremental. Only new data is decoded and it is appended to a sequence of decoded data.
3 megabyte message, IIS host: