Support WriteAsync cancellation token #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
force-pushed
the
jamesnk/writeasync-cancellation
branch
2 times, most recently
from
8e0b246
to
99dac4d
Compare
JamesNK
force-pushed
the
jamesnk/writeasync-cancellation
branch
from
d2ce394
to
6e4bec5
Compare
|
The longer I look at this PR, the more bugs I find in other places. New bug fixes:
I want to get this merged before it grows any more. |
This was referenced Apr 1, 2022
captainsafia
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1422
Turns out it was pretty complicated, especially retries and hedging. PR adds support in all places:
Also fixed a bug when hedging and writing a large message to a client stream which causes the call to be committed because it exceeded buffer size. I found this while testing.
Also fixed a bug where the server would silently continue if it was aborted while writing a message. Now throws OperationCanceledException.
Note: Contains some changes from #1644 because Grpc.Core.Api needed to be updated.