Issue #1665: added null validation #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @JamesNK ! when you have the time can you take a look? thank you in advance |
|
Change looks fine, but it would be good to verify with a test to make sure it doesn't regress. Are you comfortable with adding a unit test? There is an existing test project with the command-line tool. |
|
@JamesNK sure! I will add a unit test for this case. |
|
@JamesNK Added the Unit Test "AddProtobufReference_Without_AdditionalImportDirs" based on "AddProtobufReference_AdditionalImportDirs" but with the NULL case. |
JamesNK
approved these changes
Apr 5, 2022
Co-authored-by: James Newton-King <james@newtonking.com>
|
Thanks! |
|
@JamesNK thank you as well! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a validation for additionalImportDirs before making a split.
Fixes #1665