Fix call cancellation impacting other calls #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
approved these changes
Apr 18, 2022
Co-authored-by: Safia Abdalla <safia@safia.rocks>
JamesNK
added a commit
to JamesNK/grpc-dotnet
that referenced
this pull request
Apr 18, 2022
jtattermusch
pushed a commit
that referenced
this pull request
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the new address picker to do with cancellation.
Canceling a call also cancels other queued-up calls. The fix is to not use a share
TaskCompletionSourcebetween callers for cancellation. Instead, WaitAsync has its own TCS. WaitAsync is new in .NET 6 so a compatible version is added to older platforms.This change makes picking much simpler. It hopeful addresses
An attempt was made to transition a task to a final state when it had already completed.from #1654