Use SocketsHttpHandler.ConnectTimeout on connect #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
halter73,
BrennanConroy,
brunolins16 and
captainsafia
BrennanConroy
approved these changes
Jul 27, 2022
| var handler = new SocketsHttpHandler() | ||
| { | ||
| // ConnectTimeout is so small that CT will always be canceled before Socket is used. | ||
| ConnectTimeout = TimeSpan.FromTicks(1), |
There was a problem hiding this comment.
Doesn't TimeSpan.Zero work? We all know that using anything with real time will be flaky.
And Tick(1) actually means 15 milliseconds on windows which isn't super fast.
There was a problem hiding this comment.
TimeSpan.Zero doesn't work. The server has just started up so it should take longer than 15ms to establish the first connection. If it proves flaky, I'll come up with a better idea.
Co-authored-by: Brennan <brecon@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1828