Log sync errors in client logger interceptor example #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
brunolins16,
captainsafia and
halter73
captainsafia
approved these changes
Aug 30, 2022
| // https://docs.microsoft.com/aspnet/core/grpc/diagnostics#grpc-client-logging | ||
| var initialColor = Console.ForegroundColor; | ||
| Console.ForegroundColor = ConsoleColor.Red; | ||
| Console.WriteLine($"Call error: {ex.Message}"); |
There was a problem hiding this comment.
Suggested change
| Console.WriteLine($"Call error: {ex.Message}"); | |
| Console.WriteError($"Call error: {ex.Message}"); |
Or is there no particular need to specifically map to stderr here?
| { | ||
| // Log error to the console. | ||
| // Note: Configuring .NET Core logging is the recommended way to log errors | ||
| // https://docs.microsoft.com/aspnet/core/grpc/diagnostics#grpc-client-logging |
There was a problem hiding this comment.
Why not configure the sample to use the logging primitives then? Looks like it should be really easy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1864