Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in flaky test #1883

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 13, 2022

Fixes:

  Failed AsyncUnaryCall_CancellationDuringBackoff_CanceledStatus [27 ms]
  Error Message:
     Expected: null
  But was:  System.Threading.CancellationTokenRegistration

  Stack Trace:
     at Grpc.Net.Client.Tests.Retry.HedgingCallTests.AsyncUnaryCall_CancellationDuringBackoff_CanceledStatus() in /home/runner/work/grpc-dotnet/grpc-dotnet/test/Grpc.Net.Client.Tests/Retry/HedgingCallTests.cs:line 336
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Execution.SimpleWorkItem.<>c__DisplayClass4_0.<PerformWork>b__0()
   at NUnit.Framework.Internal.ContextUtils.<>c__DisplayClass1_0`1.<DoIsolated>b__0(Object _)

Copy link
Contributor

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@JamesNK JamesNK merged commit 9950fd7 into grpc:master Sep 14, 2022
@JamesNK JamesNK deleted the jamesnk/hedging-flaky-test branch September 14, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants