Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the extending class name when throwing ObjectDisposedException #1890

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Use the extending class name when throwing ObjectDisposedException #1890

merged 1 commit into from
Sep 26, 2022

Conversation

ellull
Copy link
Contributor

@ellull ellull commented Sep 23, 2022 •
edited

Don't use the DnsResolver class name but the extending class name when throwing the ObjectDisposedException in the PollingResolver.Resolve() method

@JamesNK
Copy link
Member

JamesNK commented Sep 23, 2022

Good spotting. Thanks for the PR!

@ellull
Copy link
Contributor Author

ellull commented Sep 24, 2022

Thanks @JamesNK.

This is my first contribution to this project and I don't know if I have to do something else now that the PR has been approved.

@JamesNK JamesNK merged commit 371d74f into grpc:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ellull @JamesNK