Update Grpc.DotNet.sln to use file scoped namespaces #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
brunolins16,
captainsafia and
halter73
BrennanConroy
approved these changes
Sep 28, 2022
|
@jtattermusch FYI. Existing PRs will have merge conflicts. Any objections? |
jtattermusch
approved these changes
Oct 5, 2022
|
just as a note, it would be nice if we have an automated style checker as part of CI, to make sure that the code style stays consistent. |
|
Sure. Shouldn't be difficult: #1900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated by a fixer. Some minor cleanup in a test file that had multiple namespace scopes.
I will update sample solutions later.
Turn off whitespace when looking at changes. There isn't much to see.