Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dotnet-grpc dependencies #1914

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 17, 2022

Fixes #1906

I updated the MSBuild packages used to locate and load projects, and that fixed the commend line tool being used with .NET 7 apps.

I also updated some other packages used by the tool in this PR. System.Comandline required some reactions (as usual...)

@JamesNK JamesNK changed the title Upgrade grpc-dotnet dependencies Upgrade dotnet-grpc dependencies Oct 17, 2022
Copy link
Contributor

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a CTI test for this scenario? The issue report indicates that it happens in a new project. Could we augment this scenario with some invocations to the CLI to validate?

@JamesNK
Copy link
Member Author

JamesNK commented Oct 18, 2022

A good idea but dotnet-grpc tool isn't high use. TBH I wouldn't want them to take up their time testing it.

@JamesNK JamesNK merged commit 947a24a into grpc:master Oct 18, 2022
@JamesNK JamesNK deleted the jamesnk/grpc-dotnet-deps-upgrade branch October 18, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet-grpc fails when running commands using .NET 7 SDK
2 participants