Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet-grpc tool to require .NET 6 #1932

Merged

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 1, 2022

There is a package conflict warning that I can't figure out in netcoreapp3.1. Updating the command line tool to net6.0 fixes it.

Note that .NET Core 3.1 hits end-of-life in December. See https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

@JamesNK
Copy link
Member Author

JamesNK commented Nov 1, 2022

@jtattermusch Nuget Build step is intermittently failing with this error:

Warning: Permanently added 'localhost' (ED25519) to the list of known hosts.
Warning: Permanently added 'localhost' (ED25519) to the list of known hosts.
Warning: Permanently added 'localhost' (ED25519) to the list of known hosts.
[01:41:34] Transferring environment variable script to build VM
[01:41:35] Transferring kokoro_log_reader.py to build VM
[01:41:36] Transferring source code to build VM
[01:41:37] Executing build script on build VM



[ID: 3662310] Executing command via SSH:
export KOKORO_BUILD_NUMBER="2357"
export KOKORO_JOB_NAME="grpc/dotnet/presubmit/build_nuget"
source /tmpfs/kokoro-env_vars.sh; cd /tmpfs/src/ ;  chmod 755 github/grpc-dotnet/kokoro/build_nuget.sh ;  PYTHON_3_VERSION="$(pyenv which python3 2> /dev/null || which python3)" ; PYTHON_2_VERSION="$(pyenv which python2 2> /dev/null || which python2)" ; if "$PYTHON_3_VERSION" -c "import psutil" ; then KOKORO_PYTHON_COMMAND="$PYTHON_3_VERSION" ; else KOKORO_PYTHON_COMMAND="$PYTHON_2_VERSION" ; fi > /dev/null 2>&1 ; echo "export KOKORO_PYTHON_COMMAND="$KOKORO_PYTHON_COMMAND"" > "$HOME/.kokoro_python_vars" ; nohup bash -c "( rm -f /tmpfs/kokoro_build_exit_code ; github/grpc-dotnet/kokoro/build_nuget.sh   ; echo \${PIPESTATUS[0]} > /tmpfs/kokoro_build_exit_code ) > /tmpfs/kokoro_build.log 2>&1" > /dev/null 2>&1 & echo $! > /tmpfs/kokoro_build.pid ; source "$HOME/.kokoro_python_vars" ; "$KOKORO_PYTHON_COMMAND" /tmpfs/kokoro_log_reader.py /tmpfs/kokoro_build.log /tmpfs/kokoro_build_exit_code /tmpfs/kokoro_build.pid /tmpfs/kokoro_log_reader.pid --start_byte 0

++ dirname github/grpc-dotnet/kokoro/build_nuget.sh
+ cd github/grpc-dotnet/kokoro/..
+ export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=true
+ DOTNET_SKIP_FIRST_TIME_EXPERIENCE=true
+ sudo apt-get install -y jq
Reading package lists...
Building dependency tree...
Reading state information...

No apt package "jq", but there is a snap with that name.
Try "snap install jq"

E: Unable to locate package jq


[ID: 3662310] Command finished after 1 secs, exit value: 100


Warning: Permanently added 'localhost' (ED25519) to the list of known hosts.
[01:41:39] Collecting build artifacts from build VM
Build script failed with exit code: 100

}

using (algorithm)
using (var algorithm = SHA256.Create())
{
return algorithm.ComputeHash(stream);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return SHA256.HashData(stream);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also restarted the Nuget build as there seem to have been an infrastructure flake (which should now be resolved).

@JamesNK JamesNK merged commit a98c621 into grpc:master Dec 7, 2022
@JamesNK JamesNK deleted the jamesnk/dotnet-grpc-update-targetframework branch December 7, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants