Support running health checks in Check method #1987
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1963
This has a behavioral change to always run health checks when the
Check
method is called, and when theWatch
method returns its initial results. I think the behavioral change is worth it because it stops the problem of apps calling the method before the health check publisher has published results.Setting
UseHealthChecksCache
to true reverts behavior to always using cached health check publisher results.New API:
namespace Grpc.AspNetCore.HealthChecks; public sealed class GrpcHealthChecksOptions { + public bool UseHealthChecksCache { get; set; } }
Usage: