RpcException API improvements #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgravell
reviewed
Dec 19, 2022
src/Grpc.Core.Api/Status.cs
Outdated
| @@ -88,7 +88,8 @@ public override string ToString() | |||
| { | |||
| if (DebugException != null) | |||
| { | |||
| return $"Status(StatusCode=\"{StatusCode}\", Detail=\"{Detail}\", DebugException=\"{DebugException}\")"; | |||
| return $"Status(StatusCode=\"{StatusCode}\", Detail=\"{Detail}\"," + | |||
| $" DebugException=\"{DebugException.GetType().Name}: {DebugException.Message}\")"; | |||
There was a problem hiding this comment.
a slightly odd choice to show the type name - especially as concrete exception types are often internal, but: not invalid - just me adding a "are you 100% sure you want this?" check
There was a problem hiding this comment.
Showing the type name is normal in Exception.ToString()
mgravell
approved these changes
Dec 19, 2022
JamesNK
approved these changes
Dec 20, 2022
src/Grpc.Core.Api/Status.cs
Outdated
| @@ -88,7 +88,8 @@ public override string ToString() | |||
| { | |||
| if (DebugException != null) | |||
| { | |||
| return $"Status(StatusCode=\"{StatusCode}\", Detail=\"{Detail}\", DebugException=\"{DebugException}\")"; | |||
| return $"Status(StatusCode=\"{StatusCode}\", Detail=\"{Detail}\"," + | |||
| $" DebugException=\"{DebugException.GetType().Name}: {DebugException.Message}\")"; | |||
There was a problem hiding this comment.
Showing the type name is normal in Exception.ToString()
Co-authored-by: James Newton-King <james@newtonking.com>
This was referenced Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses grpc/grpc#27066 and grpc/grpc#25740 (in a backward compatible way).
Two options for addressing the problem in Grpc.Core as well: