Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set WaitForDataBeforeAllocatingBuffer to false in benchmark app #2012

Merged
merged 2 commits into from
Jan 8, 2023
Merged

Set WaitForDataBeforeAllocatingBuffer to false in benchmark app #2012

merged 2 commits into from
Jan 8, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jan 8, 2023 •
edited

A small throughput boost at the cost of memory usage

mgravell
mgravell approved these changes Jan 8, 2023
View reviewed changes
Copy link
Contributor

@mgravell mgravell left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(edit: d'oh, ignore me; you already covered this in words)

LGTM

@JamesNK JamesNK merged commit 33f6ae3 into grpc:master Jan 8, 2023
@JamesNK JamesNK deleted the jamesnk/waitforreads-perf branch January 8, 2023 23:45
@amcasey
Copy link

amcasey commented Jan 10, 2023

How does this relate to the zero-byte read change, #1985?

@JamesNK
Copy link
Member Author

JamesNK commented Jan 10, 2023

Unrelated. This is on the server and is only for a benchmark app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgravell mgravell mgravell approved these changes

@ReubenBond ReubenBond Awaiting requested review from ReubenBond

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@amcasey amcasey Awaiting requested review from amcasey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JamesNK @amcasey @mgravell