Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimming issue workaround in .NET 8 #2022

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jan 19, 2023

Benchmarks error when run with .NET 8. This is the message:

C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-6584\u5opm2pa.sf0\sdk\8.0.100-alpha.1.23067.5\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1195: Unable to optimize assemblies for size: a valid runtime package was not found. Either set the PublishTrimmed property to false, or use a supported target framework when publishing. [C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-6584\4tx2lg3s.b24\grpc-dotnet\src\Grpc.Net.Common\Grpc.Net.Common.csproj::TargetFramework=netstandard2.1]
C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-6584\u5opm2pa.sf0\sdk\8.0.100-alpha.1.23067.5\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1195: Unable to optimize assemblies for size: a valid runtime package was not found. Either set the PublishTrimmed property to false, or use a supported target framework when publishing. [C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-6584\4tx2lg3s.b24\grpc-dotnet\src\Grpc.Core.Api\Grpc.Core.Api.csproj::TargetFramework=netstandard2.1]

Fix copied from dotnet/runtime#80234 dotnet/aspnetcore#45879

@JamesNK JamesNK merged commit 4bf9312 into grpc:master Jan 20, 2023
@JamesNK JamesNK deleted the jamesnk/net80-trimmingworkaround branch January 20, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants