Add additional connection and request logging to client #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
amcasey,
BrennanConroy,
mgravell and
ReubenBond
mgravell
reviewed
Feb 13, 2023
| @@ -300,6 +309,7 @@ public async ValueTask<Stream> GetStreamAsync(BalancerAddress address, Cancellat | |||
| lock (Lock) | |||
| { | |||
| _activeStreams.Add(new ActiveStream(address, socket, stream)); | |||
| SocketConnectivitySubchannelTransportLog.StreamCreated(_logger, _subchannel.Id, address, _activeStreams.Count); | |||
There was a problem hiding this comment.
logging inside the lock troubles me; is this intentional? would it perhaps be better to snag the Count inside the lock and log outside?
There was a problem hiding this comment.
I don't think this is a concern. There is logging inside locks throughout gRPC and ASP.NET Core.
mgravell
reviewed
Feb 13, 2023
| @@ -331,7 +341,7 @@ private void OnStreamDisposed(Stream streamWrapper) | |||
| if (t.Stream == streamWrapper) | |||
| { | |||
| _activeStreams.RemoveAt(i); | |||
| SocketConnectivitySubchannelTransportLog.DisposingStream(_logger, _subchannel.Id, t.Address); | |||
| SocketConnectivitySubchannelTransportLog.DisposingStream(_logger, _subchannel.Id, t.Address, _activeStreams.Count); | |||
There was a problem hiding this comment.
hmmm, maybe ignore my last comment about lock; I can't see a nice / clean way of avoiding this one, so... if we're in that situation anyway, maybe just live with it
mgravell
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional logging for #1948
Also, implement DisposeAsync on StreamWrapper in as there is a situation where it is called.