Update version to 2.52.0-dev on master #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The grpc-web tests seem to be failing even after restarting them? https://github.com/grpc/grpc-dotnet/actions/runs/4304208791/jobs/7506123308 |
JamesNK
approved these changes
Mar 2, 2023
|
I'd like to include this change in 2.52.0: #2065 It includes updating the repo to use the latest version of 7.0 SDK. That fixes the gRPC-Web tests issue you are seeing (the latest docker image uses new SDK) |
|
Merging since the grpc-web failure seems unrelated (not sure why merging #2065 didn't make the test pass upon rerunning). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll cut the release branch after this is merged.
Any blockers?