Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable NRTs throughout #2102

Merged
merged 1 commit into from Apr 27, 2023
Merged

Enable NRTs throughout #2102

merged 1 commit into from Apr 27, 2023

Conversation

mgravell
Copy link
Contributor

NRTs are not universally enabled; fix #2071

also:

  • fixup GrpcPrecondition: avoid direct throw (for better inlining); always pass arg-name when possible
  • fixup some "clean build" errors (using directives, etc)

@mgravell
- enable NRT throughout
c8cc603 
- fixup GrpcPrecondition: avoid inline throw; pass arg-name when possible
- fixup some "clean build" errors (using directives, etc)
@JamesNK
Copy link
Member

JamesNK commented Apr 27, 2023

LGTM!

@JamesNK JamesNK merged commit e270f81 into master Apr 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable nullable annotations on all projects
2 participants
@mgravell @JamesNK