Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when SslCredentials has arguments #706

Merged
merged 5 commits into from
Jan 3, 2020
Merged

Improve error message when SslCredentials has arguments #706

merged 5 commits into from
Jan 3, 2020

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Dec 27, 2019

Fixes #702

@JamesNK JamesNK changed the title Improve error message when SslCertificate has arguments Improve error message when SslCredentials has arguments Dec 30, 2019
@JunTaoLuo
Copy link
Contributor

In addition to the error message, maybe we should clarify in the doc comment as well: https://github.com/grpc/grpc-dotnet/blob/master/src/Grpc.Net.Client/GrpcChannelOptions.cs#L33-L36

@JamesNK JamesNK merged commit ae35982 into grpc:master Jan 3, 2020
@JamesNK JamesNK deleted the jamesnk/improve-sslcertificate-error branch January 3, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using SslCredentials with non-null arguments is not supported by GrpcChannel
2 participants
@JamesNK @JunTaoLuo