xds: handle removing drops (#3439)

grpc · Mar 10, 2020 · 6eb24e8 · 6eb24e8
1 parent c124257
commit 6eb24e8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/xds/internal/balancer/edsbalancer/eds_impl.go b/xds/internal/balancer/edsbalancer/eds_impl.go
@@ -169,6 +169,9 @@ func (edsImpl *edsBalancerImpl) updateDrops(dropPolicies []xdsclient.OverloadDro
 			dropsChanged = true
 		}
 	}
+	if len(edsImpl.drops) != len(newDrops) {
+		dropsChanged = true
+	}
 	if dropsChanged {
 		edsImpl.pickerMu.Lock()
 		edsImpl.drops = newDrops

diff --git a/xds/internal/balancer/edsbalancer/eds_impl_test.go b/xds/internal/balancer/edsbalancer/eds_impl_test.go
@@ -148,6 +148,20 @@ func (s) TestEDS_OneLocality(t *testing.T) {
 			t.Errorf("The second 50%% picks should be non-drops, got error %v", err)
 		}
 	}
+
+	// The same locality, remove drops.
+	clab6 := xdsclient.NewClusterLoadAssignmentBuilder(testClusterNames[0], nil)
+	clab6.AddLocality(testSubZones[0], 1, 0, testEndpointAddrs[2:3], nil)
+	edsb.HandleEDSResponse(xdsclient.ParseEDSRespProtoForTesting(clab6.Build()))
+
+	// Pick without drops.
+	p6 := <-cc.newPickerCh
+	for i := 0; i < 5; i++ {
+		gotSCSt, _ := p6.Pick(balancer.PickInfo{})
+		if !cmp.Equal(gotSCSt.SubConn, sc3, cmp.AllowUnexported(testSubConn{})) {
+			t.Fatalf("picker.Pick, got %v, want SubConn=%v", gotSCSt, sc3)
+		}
+	}
 }
 
 // 2 locality