Skip to content

Commit

Permalink
Change grpcrand implementation to use Go top-level random functions f…
Browse files Browse the repository at this point in the history
…or go1.21+
  • Loading branch information
Kamyar Mirzavaziri committed Jan 17, 2024
1 parent ddd377f commit 88e8787
Show file tree
Hide file tree
Showing 2 changed files with 74 additions and 0 deletions.
3 changes: 3 additions & 0 deletions internal/grpcrand/grpcrand.go
@@ -1,3 +1,6 @@
//go:build !go1.21
// +build !go1.21

/*
*
* Copyright 2018 gRPC authors.
Expand Down
71 changes: 71 additions & 0 deletions internal/grpcrand/grpcrand_go1.21.go
@@ -0,0 +1,71 @@
/*
*
* Copyright 2024 gRPC authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/

// Package grpcrand implements math/rand functions in a concurrent-safe way
// with a global random source, independent of math/rand's global source.
package grpcrand

import "math/rand"

// This implementation will be used for Go version 1.21 or newer.
// For older versions, the original implementation with mutex will be used.

// Int implements rand.Int on the grpcrand global source.
func Int() int {

Check failure on line 29 in internal/grpcrand/grpcrand_go1.21.go

View workflow job for this annotation

GitHub Actions / tests (tests, 1.20)

Int redeclared in this block

Check failure on line 29 in internal/grpcrand/grpcrand_go1.21.go

View workflow job for this annotation

GitHub Actions / tests (tests, 1.19)

Int redeclared in this block
return rand.Int()
}

// Int63n implements rand.Int63n on the grpcrand global source.
func Int63n(n int64) int64 {

Check failure on line 34 in internal/grpcrand/grpcrand_go1.21.go

View workflow job for this annotation

GitHub Actions / tests (tests, 1.20)

Int63n redeclared in this block

Check failure on line 34 in internal/grpcrand/grpcrand_go1.21.go

View workflow job for this annotation

GitHub Actions / tests (tests, 1.19)

Int63n redeclared in this block
return rand.Int63n(n)
}

// Intn implements rand.Intn on the grpcrand global source.
func Intn(n int) int {

Check failure on line 39 in internal/grpcrand/grpcrand_go1.21.go

View workflow job for this annotation

GitHub Actions / tests (tests, 1.20)

Intn redeclared in this block

Check failure on line 39 in internal/grpcrand/grpcrand_go1.21.go

View workflow job for this annotation

GitHub Actions / tests (tests, 1.19)

Intn redeclared in this block
return rand.Intn(n)
}

// Int31n implements rand.Int31n on the grpcrand global source.
func Int31n(n int32) int32 {

Check failure on line 44 in internal/grpcrand/grpcrand_go1.21.go

View workflow job for this annotation

GitHub Actions / tests (tests, 1.20)

Int31n redeclared in this block

Check failure on line 44 in internal/grpcrand/grpcrand_go1.21.go

View workflow job for this annotation

GitHub Actions / tests (tests, 1.19)

Int31n redeclared in this block
return rand.Int31n(n)
}

// Float64 implements rand.Float64 on the grpcrand global source.
func Float64() float64 {

Check failure on line 49 in internal/grpcrand/grpcrand_go1.21.go

View workflow job for this annotation

GitHub Actions / tests (tests, 1.20)

Float64 redeclared in this block

Check failure on line 49 in internal/grpcrand/grpcrand_go1.21.go

View workflow job for this annotation

GitHub Actions / tests (tests, 1.19)

Float64 redeclared in this block
return rand.Float64()
}

// Uint64 implements rand.Uint64 on the grpcrand global source.
func Uint64() uint64 {
return rand.Uint64()
}

// Uint32 implements rand.Uint32 on the grpcrand global source.
func Uint32() uint32 {
return rand.Uint32()
}

// ExpFloat64 implements rand.ExpFloat64 on the grpcrand global source.
func ExpFloat64() float64 {
return rand.ExpFloat64()

Check warning on line 65 in internal/grpcrand/grpcrand_go1.21.go

View check run for this annotation

Codecov / codecov/patch

internal/grpcrand/grpcrand_go1.21.go#L64-L65

Added lines #L64 - L65 were not covered by tests
}

// Shuffle implements rand.Shuffle on the grpcrand global source.
var Shuffle = func(n int, f func(int, int)) {
rand.Shuffle(n, f)

Check warning on line 70 in internal/grpcrand/grpcrand_go1.21.go

View check run for this annotation

Codecov / codecov/patch

internal/grpcrand/grpcrand_go1.21.go#L69-L70

Added lines #L69 - L70 were not covered by tests
}

0 comments on commit 88e8787

Please sign in to comment.