Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Wait for Ready" RPCs retry even if data was written to the wire #1532

Closed
dfawley opened this issue Sep 20, 2017 · 3 comments · Fixed by #1597
Closed

"Wait for Ready" RPCs retry even if data was written to the wire #1532

dfawley opened this issue Sep 20, 2017 · 3 comments · Fixed by #1597
Assignees

Comments

@dfawley
Copy link
Member

dfawley commented Sep 20, 2017

Once data is written to the wire, unless we are certain the remote server did not receive it, gRPC cannot resend an RPC. However, we are doing this in many cases. E.g., in the event an error occurs while waiting for a response from the remote server:

grpc-go/call.go

Lines 292 to 294 in 1253dac

if _, ok := err.(transport.ConnectionError); (ok || err == transport.ErrStreamDrain) && !c.failFast {
continue
}

@xiang90
Copy link
Contributor

xiang90 commented Oct 17, 2017

for read request, we do want to retry. i think we need to provide options to users.

@dfawley
Copy link
Member Author

dfawley commented Oct 17, 2017

This would be covered by retry support (gRFC A6), but it isn't otherwise a part of gRPC.

@xiang90
Copy link
Contributor

xiang90 commented Oct 17, 2017

@dfawley awesome. good to learn.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants